fix(core): fix an edge case for split_off operation for RrbVec #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case that brakes the
push
operation onRrbVec
. Here are the steps to reproduce it:RrbVec
instance exactly of theBRANCH_FACTOR * BRANCH_FACTOR
size.BRANCH_FACTOR * BRANCH_FACTOR - BRANCH_FACTOR
.A simple example for a vector that has a branching factor of 4:
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]
.[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11]
and[12, 13, 14, 15]
.The right hand size vector will have a full tail. The bug was that the tail was not pushed onto tree when full. When trying to push an ordinary item,
16
for example, it will overflow the vector and cause a panic.