Implement automatic precompilation #29
Conversation
Following the path of Adwaita, this commit implements the automation to automatically precompile the GTK3 theme versions to gresource binary files, to improve performance of theme rendering, and avoid unnecessary re-read and re-parsing of the theme on every app run. . Given that the theme is coded in sass to begin with directly altering it is not a reasonable thing to do, and so we don't loose anything by having the installed theme in binary form, specially when accessing the sources is easy enough. . The takes #656 and adds to this proposed commit and ensures that precompilation works for both GTK+3.18 and later GTK+ versions
|
Some more useful information may be found here in the 3 listed commits: |
|
hmm - totally forgot about this. I'll have a play. |
|
ok - the final commit shows the compilation in action - so compile as normal on branch fix656 however a very odd thing which I can't figure out - if you delete all Arc theme folders (i.e. start from fresh if you re-run No idea why. EDIT: think I know - need to rejig compile-resources.sh slightly - will have a look tonight. |
|
@NicoHood should be working now. Please have a play. If ready I would suggest use the squash and merge option to collapse all the individual commits into one commit. |
|
I've been using this for few days, and haven't encountered issues on gtk+ 3.22. I added a few minor notes on the |
|
@jnsh Could you open a PR with your changes against the branch |
|
I will revise.
On Mon, 10 Sep 2018, 18:31 Nico, <[email protected]<mailto:[email protected]>> wrote:
@jnsh<https://github.com/jnsh> Could you open a PR with your changes against the branch fix656? Or @fossfreedom<https://github.com/fossfreedom> Fixes the requested changes. Thanks for the review!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA8zkH4fhzE7olMHOo_Fm3b7mxCwyXZfks5uZqINgaJpZM4RZe1E>.
|
|
@fossfreedom Are you still planning on updating this PR? |
|
Sorry. Waist deep in budgie desktop matters at the moment. Happy to review any PRs
On Sat, 22 Sep 2018, 11:39 jnsh, <[email protected]<mailto:[email protected]>> wrote:
@fossfreedom<https://github.com/fossfreedom> Are you still planning on updating this PR?
I can also open a new PR based on this branch with the updates I suggested if you're busy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA8zkGmAQaMJae_ahVXmmFbQ5gkS7rHTks5udhNggaJpZM4RZe1E>.
|
|
Nice to see this merged. I was also working for a updated PR as promised, but ended up changing the gtk3 version detection in I'm curious though, why did you add the |
Fixes #28
@fossfreedom You said this works for gtk > 3.20 but not for 3.18 (ubuntu 16.04). For the sassc PR you already figured out how to add an if statement to the makefile, how about also adding this change to the new release?