Remove margin:auto from cinnamon menu applet and default theme #3
Conversation
Upstream PR #788 - This avoids warning messages as margin:auto is not supported in cinnamon 3.4 and later
So you mean if someone uses an older version of cinnamon we can not make the theme compatible for both? If so, we should use the latest compatible version, as you wrote in the Readme. Looks good to me :) |
|
indeed. I'm loathed to introduce scss "if" type statements for version specific stuff because just like GNOME, things evolve and change between cinnamon versions and the logic and testing complexities will increase. |
|
From my point of view we should only support versions back to the latest debian and the latest ubuntu LTS. All older versions of arc probably still work fine, as the desktop environments also wont get major updates. Otherwise it will get harder too maintain. |
|
Agreed |
Upstream PR #788 - This avoids warning messages as margin:auto
is not supported in cinnamon 3.4 and later
favourites section as per picture same before and after.
Tested cinnamon 3.4.6 ubuntu 17.10
unlike GNOME there isn't any versioning restrictions for cinnamon - so README updated instead.