Inline extern function calls in impl_interface

arceos-org · Jan 18, 2025 · d3c88df · d3c88df
1 parent c999c6f
commit d3c88df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -61,8 +61,10 @@ struct HelloIfImpl;
 
 // #[impl_interface]
 impl HelloIf for HelloIfImpl {
+    #[inline]
     fn hello(&self, name: &str, id: usize) -> String {
         {
+            #[inline]
             #[export_name = "__HelloIf_hello"]
             extern "Rust" fn __HelloIf_hello(name: &str, id: usize) -> String {
                 let _impl: HelloIfImpl = HelloIfImpl;

diff --git a/src/lib.rs b/src/lib.rs
@@ -29,7 +29,7 @@ pub fn def_interface(attr: TokenStream, item: TokenStream) -> TokenStream {
     if !attr.is_empty() {
         return compiler_error(Error::new(
             Span::call_site(),
-            "expect an empty attribute: `#[crate_interface_def]`",
+            "expect an empty attribute: `#[def_interface]`",
         ));
     }
 
@@ -89,7 +89,7 @@ pub fn impl_interface(attr: TokenStream, item: TokenStream) -> TokenStream {
     if !attr.is_empty() {
         return compiler_error(Error::new(
             Span::call_site(),
-            "expect an empty attribute: `#[crate_interface_impl]`",
+            "expect an empty attribute: `#[impl_interface]`",
         ));
     }
 
@@ -138,11 +138,13 @@ pub fn impl_interface(attr: TokenStream, item: TokenStream) -> TokenStream {
             };
 
             let item = quote! {
+                #[inline]
                 #(#attrs)*
                 #vis
                 #sig
                 {
                     {
+                        #[inline]
                         #[export_name = #extern_fn_name]
                         extern "Rust" #new_sig {
                             #call_impl