Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page_table: allow more generic virtual addresses in page table #2

Merged
merged 1 commit into from
Jul 31, 2024
Merged

page_table: allow more generic virtual addresses in page table #2

merged 1 commit into from
Jul 31, 2024

Conversation

aarkegz
Copy link
Contributor

@aarkegz aarkegz commented Jul 30, 2024 •
edited
Loading

An associated type named VirtAddr is added to PagingMetaData. PageTable64 has been updated. Not tested yet. @equation314 please review.

equation314
equation314 reviewed Jul 30, 2024
View reviewed changes
@aarkegz
Copy link
Contributor Author

aarkegz commented Jul 31, 2024 •
edited
Loading

@equation314 improvements pushed.

equation314
equation314 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@equation314 equation314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
But it introduces too many senseless commits, could you rebase them into one?

@aarkegz
Copy link
Contributor Author

aarkegz commented Jul 31, 2024

Thanks! But it introduces too many senseless commits, could you rebase them into one?

I'll do it tonight.

@aarkegz aarkegz force-pushed the generic_virt_addr branch from 4327674 to 970d144 Compare July 31, 2024 16:19
@aarkegz
Copy link
Contributor Author

aarkegz commented Jul 31, 2024

Commits merged.

@equation314 equation314 merged commit fec035c into arceos-org:main Jul 31, 2024
5 checks passed
@aarkegz
Copy link
Contributor Author

aarkegz commented Aug 1, 2024

Thanks 🙏

@aarkegz aarkegz deleted the generic_virt_addr branch August 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equation314 equation314 equation314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarkegz @equation314