Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1292 Fix sample deletion #1293

Merged
merged 2 commits into from
Oct 11, 2023
Merged

1292 Fix sample deletion #1293

merged 2 commits into from
Oct 11, 2023

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Sep 11, 2023

Fixes #1292

Reverting the fix causes the added test to fail (as desired):

arches-for-science % PYTHONPATH='../arches' python3 manage.py test --settings=arches_for_science.test_settings --keepdb
Found 2 test(s).
Using existing test database for alias 'default'...
creating index : test_terms
creating index : test_concepts
creating index : test_resources
System check identified no issues (1 silenced).
.F
======================================================================
FAIL: test_create_delete_sample (arches_for_science.tests.AnalysisAreaAndSampleTakingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jwalls/prj/arches-for-science/arches_for_science/tests.py", line 154, in test_create_delete_sample
    self.assertEqual(response.status_code, 200)
AssertionError: 500 != 200

----------------------------------------------------------------------
Ran 2 tests in 3.566s

@jacobtylerwalls jacobtylerwalls changed the base branch from master to dev/1.1.x September 11, 2023 22:45
@jacobtylerwalls jacobtylerwalls changed the base branch from dev/1.1.x to rename September 11, 2023 22:45
Base automatically changed from rename to dev/1.1.x September 12, 2023 00:34
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review September 15, 2023 14:44
Copy link
Contributor

@njkim njkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!
Deletion works as described without an error.
The test runs ok.

@njkim njkim merged commit 04c4f9e into dev/1.1.x Oct 11, 2023
1 check passed
@jacobtylerwalls jacobtylerwalls deleted the 1292-sample-deletion branch October 11, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample deletion doesn't work
2 participants