Fix state restoration when going backward #1314 #1319
Conversation
Restoring the state of the selected values in the sidebar expected there to be values in targetResources. If this is a backwards navigation, there are no targetResources, and so restoring state from by starting from startValue and sprinkling in stuff from targetResources will fail. Need to sprinkle in stuff from value(), hence value() needs to be a real obj, not a resource id.
There was a problem hiding this comment.
The step itself seems to be working well as described. But the step does not save the collection consistently. At some point, it stops working, although the step is showing the user selection correctly.
@jacobtylerwalls Is this issue a part of another ticket? (in that case this can be merged)
|
Hey @njkim I'm not certain, but I'm happy to look into it. Do you have a set of steps that reproduces the issue for you? Feel free to take a short video if that's easier. |
@jacobtylerwalls It looks I am seeing is similar to this issue #1232 |
Closes #1314
self.value()is shaped like an array of resources rather than of resource ids.This is because for state restoration to work when going backward, we can't rely on all the needed items for the selected sidebar existing in the search results--the user hasn't done a search in this case! What was happening was that the selected resources weren't appearing in the sidebar.
Testing instructions:
Test adding and deleting physical things to projects, including navigating backward. Check sidebar/UI agrees with reality. Check highlighting.