Lint backend #1557
Merged
Lint backend #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See failed action on first commit 👍 |
chiatt
approved these changes
Mar 13, 2024
| @@ -336,6 +336,8 @@ def save_removed_from_tile(self, request, sample_resourceid, removed_from_resour | |||
| ) | |||
| tile.save(transaction_id=transactionid, request=request, index=False) | |||
|
|
|||
| return tile | |||
There was a problem hiding this comment.
Oh - interesting. It caught a potentially serious bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI step to lint the backend. Discussed with @aarongundel after the avoidable error in #1551.
Alternatives considered
pylint -- would have caught #1551, deeply configurable
flake8 -- focused more on style/cosmetics. wasn't immediately clear how to just filter down on the important stuff.
ruff -- the new hotness in python linting, but I still don't think it would have caught #1551. sure it will one day, though, and we can switch over when it's fast/mature.