Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies doc to be a little more use-case focused #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidthor
Copy link
Member

Closes #22 by updating the dependencies doc

@davidthor davidthor requested a review from DevMandy March 26, 2023 15:28
create a new component from one of Architect's starter projects.

```sh
$ architect init backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command needs more instruction. We need to explain what they should select from the dropdown list and that a new project will be created in the directory provided (backend). We should explain that this command is cloning one of our starter projects locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which to select. We don't publish the node-rest-api project as a starter project any longer. We publish the nodejs project, which contains a frontend, instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, but I think if we verbosely explain the init command every time we cite it we're going to have a LOT of duplicate documentation.

What I think makes more sense given your two comments is not to make this a full "guide" with running examples, but rather to simply talk about the dependencies feature abstractly and the register and link command respectively. If you agree I can make some changes to shorten.

and call it `frontend`.

```sh
$ architect init frontend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell them what to select from the dropdown list.

AUTH_EXTERNAL: ${{
dependencies['authentication'].services.auth.interfaces.main.ingress.url
}}
BACKEND_ADDR: ${{ dependencies.backend.services.api.interfaces.main.url }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would explain where this address comes from and possibly link to components/service-discovery

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you bring in service discovery below. It would still be helpful to explain here that the address comes from the backend app's service declaration in its own architect.yml file.

components/dependencies.mdx Outdated Show resolved Hide resolved
components/dependencies.mdx Outdated Show resolved Hide resolved
```yaml
Citing dependencies as part of your component is not the most natural way for developers to integrate with
software made by other teams, but its also the only way to achieve [on-demand environments](/environments/pull-request)
for [distributed applications](/architecture/microservices).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked page doesn't exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! My bad. Making changes.

for [distributed applications](/architecture/microservices).

Every time a component is deployed with Architect, it will automatically deploy (if needed) and connect to
cited dependencies. Perhaps even more impressive than that is that it will also deploy the dependencies OF your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cited dependencies. Perhaps even more impressive than that is that it will also deploy the dependencies OF your
cited dependencies. Perhaps even more impressive than that is that it will also deploy the *dependencies your

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this suggestion captures what I was trying to say which is that we deploy the dependencies you didn't know you had as well (e.g. the dependencies OF your own dependencies). Is there a better way to phrase that that you can think of?


Every time a component is deployed with Architect, it will automatically deploy (if needed) and connect to
cited dependencies. Perhaps even more impressive than that is that it will also deploy the dependencies OF your
component's dependencies and ensure they're integrated as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
component's dependencies and ensure they're integrated as well.
dependencies* and ensure they're integrated as well.

components/dependencies.mdx Outdated Show resolved Hide resolved
components/dependencies.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talk more about the use cases for dependencies in related docs
2 participants