fix: overwrite at in target jar. #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 秋雨落 <[email protected]>
Signed-off-by: 秋雨落 <[email protected]>
|
The AT definitely should not come from the common project (if it does, the error message is correct). It actually comes from the previous build of the project since the old jar contents weren't deleted in 1.9 (FabricMC#1270). I've just committed a fix for that bug which also takes care of this one. Thanks for the PR in any case - the underlying issue is definitely a hard one to find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all projects with arch loom 1.9, the
remapJarwill fail due to this exception if you didn'tcleanbefore thebuild.The at already exists comes from the common project (shadow bundle), we can just ignore and delete it.