Fixed unsafe property reading #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing arguments around using Java environment properties is unsafe and causes problems when building with architectury plugin with Gradle parallel build enabled. This moves all the properties into
TransformerContext, since they are unique per transform task.The
Loggerstill has an old global access API just to keep things working. Same withSimpleTransformerContext, it still reads values from environment properties to maintain some compatibility. However, those should be replaced in the future. Some changes also have to be done on architectury-plugin to get it to work with these changes. There will be a pull request for it.