Rework build_iso.sh
#1805
Draft
Rework build_iso.sh
#1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefiles
force-pushed
the
rework-iso
branch
3 times, most recently
from
aa68b1a
to
e1834f5
Compare
|
The script was never really meant to be used on a broader scale. It's only real purpose was to run in That said the improvements might be quite useful. Let me test this out before merging :) |
|
Understood. After some more thought on the matter I feel this pull request should not be merged. At least not yet. |
lavafroth
reviewed
Jun 14, 2023
| echo "This ISO was built from Git SHA $GITHUB_SHA" | ||
| echo "Type archinstall to launch the installer." | ||
| _EOF_ | ||
|
|
||
| pacman -Sy | ||
| pacman --noconfirm -S git archiso |
There was a problem hiding this comment.
Perhaps you can add the --disable-download-timeout flag here. It helps with errors like Operation too slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the development message to motd. Move archinstall build from zprofile to a script. Create a service that is enabled on boot to run the script. Wait for completion of the service at root login shell (zprofile).
Currently the build of archinstall in the ISO environment is output to the console. This is problematic because there is not a scrollback buffer in the console to review the output. The changes in this pull request will allow the review of the build with
journalctl -u build-archinstall.Another issue with the current implementation is changing tty or executing tmux and opening panes and windows will read and execute the zprofile causing archinstall to be built and installed again. This pull request does not have this problem because the script to build and install archinstall is started by the service.