Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bootloader installation #2032

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented Sep 4, 2023

This fixes:

When installing the bootloader, the respective device was searched by the boot partition path. However, the search was only conducted on the in-memory device cache which is not updated after any partitioning and will therefore not contain the newly created partitions.

We'll have therefore have to retrieve the parent partition path from a new lsblk call.

@svartkanin svartkanin changed the title Fix 1982 | Bootloader installation Fix Bootloader installation Sep 4, 2023
@1995parham 1995parham mentioned this pull request Sep 9, 2023
@Torxed
Copy link
Member

Torxed commented Sep 13, 2023

Great catch!

@svartkanin svartkanin merged commit 0258b03 into archlinux:master Sep 14, 2023
5 of 6 checks passed
@svartkanin svartkanin deleted the fix-1982 branch September 14, 2023 10:56
@ghost
Copy link

ghost commented Sep 19, 2023

I believe this fix is important enough to get a new Arch ISO release with it.

@Torxed
Copy link
Member

Torxed commented Sep 20, 2023

This and a few other fixes are critical enough for a new release yes.
And it's coming! For the majority of users we have until the ~25:th to package up any remaining fixes we want to submit - as most people get the new version via downloading the new ISO that's built/released on the 1:st every month.

But hopefully by the weekend the new release drops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants