Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adaptive height issue with divider #2561

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

oljc
Copy link
Member

@oljc oljc commented Jul 13, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

竖向时无法跟随周围的高度变化。
复现地址

Solution

调整为最小高度1em,其他自动跟随外层高度撑开
其实原本这个问题可以使用者直接通过style解决,就看这个特性是否变为组件默认。
image

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
divider 修复竖向自适应高度 fix adaptive height issue with divider

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion
Copy link
Member

flsion commented Jul 14, 2023

@LIjiAngChen8 这里占满容器的高度更好,更符合一些实际使用场景

@flsion flsion self-assigned this Jul 14, 2023
@flsion flsion added the 💪🏻 Enhancement feature enhancement label Jul 14, 2023
@flsion flsion added this to the 2.48.1 milestone Jul 14, 2023
@flsion flsion merged commit d044e10 into arco-design:main Jul 14, 2023
2 of 4 checks passed
@oljc oljc deleted the fix-divider branch February 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪🏻 Enhancement feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants