Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cascader): fix empty state in Cascader Virtual list #2686

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

oljc
Copy link
Member

@oljc oljc commented Sep 4, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

开启虚拟列表时空数据不显示空状态 #2684

Solution

📌 为保持不影响以前的dom层级结构添加了外层。实际不加外层(或直接用div包裹)也许会更好看。
image

加(与以前保持一致):
image
未添加(居中):
image

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
cascader 修复开启虚拟列表时空状态不显示 fix empty state in Cascader Virtual list #2684

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion flsion self-assigned this Sep 8, 2023
@flsion flsion added the 🐛 Bug Something isn't working label Sep 8, 2023
@flsion flsion added this to the 2.51.1 milestone Sep 8, 2023
@flsion flsion merged commit 5784312 into arco-design:main Sep 8, 2023
2 of 4 checks passed
@oljc oljc deleted the fix-cascader-empty branch February 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants