Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): adjust incorrect type definitions and documentation #2924

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Jan 15, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

#2850
#336

Solution

  1. 更正拼写错误
  2. 修复 ImagePreviewProps 类型定义问题。
  3. 修复 popupContainer 类型定义缺失

How is the change tested?

打包后通过更改软连接测试 无异常。

Changelog

Component Changelog(CN) Changelog(EN) Related issues
image 修复错误的类型定义和文档说明 adjust incorrect type definitions and documentation Close #2850
image-preview 修正单词拼写错误 fix spelling mistakes Close #2744
input-password 修正文档单词拼写错误 fix spelling mistakes Close #2744

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion flsion added the 🐛 Bug Something isn't working label Jan 19, 2024
@flsion flsion added this to the 2.54.3 milestone Jan 19, 2024
@flsion flsion merged commit 153ab55 into arco-design:main Jan 19, 2024
2 of 4 checks passed
@oljc oljc deleted the fix-image-type branch February 2, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<a-image /> 组件 preview-props 配置项并不可选 Image component several spelling errors
2 participants