fix(date-picker): refactor date utility functions and week picker to correctly show selected week #2970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
#2896
Solution
Locale methods in Dayjs sometimes does not change the way dates respond to
weekStart
customizations. Therefore we rewrite the methodsstartOfWeek
that returns the start day of week andisSameWeek
that compares the week numbers of two dates,calculating week numbers that changes with
weekStart
.Dayjs 中的 locale 方法有时不会改变日期对自定义
weekStart
的响应方式。因此,重写了startOfWeek
方法和isSameWeek
方法以计算随
weekStart
变化的周数。How is the change tested?
Changelog
dayStartOfWeek
in demoChecklist:
npm run test
)feature
branch and othersshould be submitted to
main
branch)Other information