Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct the type definition for popupContainer #2998

Merged
merged 1 commit into from
May 10, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Feb 27, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

image

使用了 trigger 的组件很多,但它们的 popupContainer 的类型定义不统一。

Solution

与 trigger 的 popupContainer 定义一致

popupContainer: {
      type: [String, Object] as PropType<string | HTMLElement>,
 },

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
修正 popupContainer 的类型定义 correct the type definition for popupContainer

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

方便 CR 没有 docgen

Copy link

codesandbox bot commented Feb 27, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@flsion flsion added the 📚 Typescript Typescript modify label May 10, 2024
@flsion flsion added this to the 2.55.2 milestone May 10, 2024
@flsion flsion merged commit a2a98d6 into arco-design:main May 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Typescript Typescript modify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants