Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): fix overlap between step button and suffix/append #3005

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Feb 28, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

开启 suffix 插槽或者 append 时会出现步进按钮重叠。

问题描述 #2999
相关 PR #3003

Solution

原本的样式代码中有相关的实现但有缺陷未生效。
针对 vue 版实现修改最终与React demo 效果一致。

未hover 时:

image

hover 时:
image

iShot_2024-02-28_22.58.24.mp4

How is the change tested?

snapshots没变化

Changelog

Component Changelog(CN) Changelog(EN) Related issues
input-number 修复步进按钮与 suffix/append 的样式重叠 fix overlap between step button and suffix/append Closes #2999

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Feb 28, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@flsion flsion self-assigned this Mar 1, 2024
@flsion flsion added the 🐛 Bug Something isn't working label Mar 1, 2024
@flsion flsion added this to the 2.54.6 milestone Mar 1, 2024
@flsion flsion merged commit 9e01577 into arco-design:main Mar 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input-number componse step button style bug
2 participants