Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CANFD support to Linux CAN #33

Merged
merged 10 commits into from
Sep 18, 2024
Merged

Add CANFD support to Linux CAN #33

merged 10 commits into from
Sep 18, 2024

Conversation

alaa-az
Copy link
Contributor

@alaa-az alaa-az commented Sep 8, 2024

closes #24

@alaa-az alaa-az marked this pull request as ready for review September 8, 2024 02:05
@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 13, 2024

@ardera Can you please review this.

@ardera
Copy link
Owner

ardera commented Sep 14, 2024

Hey @alaa-az sorry for the wait.

What CAN hardware did you test this with?

@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 14, 2024

Hello @ardera on this: https://www.peak-system.com/PCAN-USB-FD.365.0.html?&L=1, also tested on virtual CAN

ardera
ardera reviewed Sep 14, 2024
View reviewed changes
Copy link
Owner

@ardera ardera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just some minor stuff. Thanks a lot for the contribution!

packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 15, 2024

Fixes are done, Thank you in advance

ardera
ardera reviewed Sep 15, 2024
View reviewed changes
packages/linux_can/lib/src/data_classes.dart Outdated Show resolved Hide resolved
packages/linux_can/example/lib/main.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
packages/linux_can/lib/src/platform_interface.dart Outdated Show resolved Hide resolved
@ardera
Copy link
Owner

ardera commented Sep 15, 2024

Sorry I pointed you in the wrong direction before, after this is fixed it's ready to merge :)

@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 15, 2024 •
edited
Loading

Don't worry I should have figured this out by myself. Done now

@alaa-az alaa-az requested a review from ardera September 17, 2024 16:18
@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 18, 2024

Perfect solution, it works with Virtual CAN.

@alaa-az alaa-az requested a review from ardera September 18, 2024 09:59
@ardera ardera merged commit 3a86b07 into ardera:main Sep 18, 2024
@ardera
Copy link
Owner

ardera commented Sep 18, 2024

merged it

thanks for the contribution!

@alaa-az
Copy link
Contributor Author

alaa-az commented Sep 18, 2024

Thank you for this repo

@alaa-az
Copy link
Contributor Author

alaa-az commented Oct 25, 2024

Hello Hannes: Are you planing on releasing linux_can new version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardera ardera ardera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[linux_can] Would it be possible to add CAN FD support to linux_can ?
2 participants
@alaa-az @ardera