fix: access arweave at different levels of default for esm bundle compat PE-7069 #206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #206 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 25 25
Lines 3486 3486
Branches 159 159
=======================================
Hits 3263 3263
Misses 223 223 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.20.1-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| const ArweaveClass = | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore -- Access the correct class constructor for Arweave | ||
| ArweaveModule.default?.default || ArweaveModule.default || ArweaveModule; |
There was a problem hiding this comment.
nit: consider making this an export and using it where we want to use Arweave
There was a problem hiding this comment.
right now we just access it here and then in test env. using this exported version in our test env just causes compiler issues due to this being a const. as arweave-js exports right now, it seems like we need this pattern in each non-test file that we try to access init or new
|
🎉 This PR is included in version 1.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.