make the simd_runtime_generate macro explicitly unsafe #52
+23
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might require that consumers of this crate need to wrap their _runtime_select function in a safe block
This might require that consumers of this crate need to wrap their _compiletime_select function in a safe block
arduano
previously approved these changes
Jan 23, 2023
arduano
dismissed
their stale review
After more consideration, I think we could approach this differently
|
What makes those generated functions explicitly unsafe? Isn't it only the fact that the cpu might not have those instructions? If so, then isn't the runtime generate function completely safe, because it ensures at runtime that the instructions that it will use do exist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue it would be better that the
simd_xxx_generatemacros are explictlyunsafe.This has an impact for consumers of this crate, so a (minor) version bump might be applicable.