Skip to content

Commit

Permalink
Fixed protoc.zip release artifact missing google/rpc/status.proto (#…
Browse files Browse the repository at this point in the history
…2761)

* Using buf to produce protoc artifacts for release

* Updated gh workflows
  • Loading branch information
cmaglie authored Nov 21, 2024
1 parent 67eb95a commit c3d05d6
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/check-protobuf-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- uses: bufbuild/buf-action@v1
- name: Install buf
uses: bufbuild/buf-action@v1
with:
setup_only: true

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish-go-nightly-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,11 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Install buf
uses: bufbuild/buf-action@v1
with:
setup_only: true

- name: Collect proto files
env:
NIGHTLY: true
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish-go-tester-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Install buf
uses: bufbuild/buf-action@v1
with:
setup_only: true

- name: Build
run: |
PACKAGE_NAME_PREFIX=${{ needs.package-name-prefix.outputs.prefix }}
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release-go-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,11 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Install buf
uses: bufbuild/buf-action@v1
with:
setup_only: true

- name: Collect proto files
run: task protoc:collect

Expand Down
6 changes: 3 additions & 3 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,10 @@ tasks:

protoc:collect:
desc: Create a zip file containing all .proto files in DIST_DIR
dir: rpc
cmds:
- mkdir --parents ../{{.DIST_DIR}}
- zip -r ../{{.DIST_DIR}}/{{.PROJECT_NAME}}_{{.VERSION}}_proto.zip * -i \*.proto
- mkdir --parents {{.DIST_DIR}}
- buf export . -o {{.DIST_DIR}}/proto
- cd {{.DIST_DIR}}/proto && zip -r ../{{.PROJECT_NAME}}_{{.VERSION}}_proto.zip .

protoc:format:
desc: Perform formatting of the protobuf definitions
Expand Down

0 comments on commit c3d05d6

Please sign in to comment.