Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] refactor: made some golang modules private (part 3) #2467

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 14, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

In preparation for the release of 1.0.0, we will make most of the root packages internal and expose only the packages commands and rpc (that are 1:1 correlated with the gRPC API).

  • Made client_example example internal inside rpc package
  • Mode docsgen internal
  • Made i18n library internal (this one may be a candidate to became a standalone library)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes

Other information

@cmaglie cmaglie self-assigned this Dec 14, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 14, 2023
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Dec 14, 2023
@cmaglie cmaglie force-pushed the internalize-modules branch from ef6c277 to a3bef94 Compare December 14, 2023 17:05
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9476de) 67.62% compared to head (a3bef94) 67.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
- Coverage   67.62%   67.61%   -0.02%     
==========================================
  Files         204      207       +3     
  Lines       20562    20710     +148     
==========================================
+ Hits        13905    14003      +98     
- Misses       5519     5563      +44     
- Partials     1138     1144       +6     
Flag Coverage Δ
unit 67.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie
Copy link
Member Author

cmaglie commented Dec 14, 2023

The failing markdown link-check is a false negative.
The missing link https://github.com/arduino/arduino-cli/blob/master/rpc/internal/client_example will become valid after merging the PR.

@cmaglie cmaglie merged commit 0e21e6f into arduino:master Dec 18, 2023
105 of 106 checks passed
@cmaglie cmaglie deleted the internalize-modules branch December 18, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants