Fix legacy settings in Twill 3 (#2417)

* Fix legacy settings in Twill 3

* Add explicit View facade import

---------

Co-authored-by: Quentin Renard <[email protected]>

src/Http/Controllers/Admin/SettingController.php

@@ -9,6 +9,7 @@
 use Illuminate\Http\Request;
 use Illuminate\Routing\Redirector;
 use Illuminate\Routing\UrlGenerator;
+use Illuminate\Support\Facades\View;
 use Illuminate\View\Factory as ViewFactory;
 
 class SettingController extends Controller
@@ -61,18 +62,26 @@ public function __construct(
      */
     public function index(string $section)
     {
-        return $this->viewFactory->exists('twill.settings.' . $section)
-        ? $this->viewFactory->make('twill.settings.' . $section, [
+        if (! $this->viewFactory->exists('twill.settings.' . $section)) {
+            return $this->redirector->back();
+        }
+
+        $formFields = $this->settings->getFormFieldsForSection($section);
+
+        View::share('form', [
+            'form_fields' => $formFields,
+        ]);
+
+        return $this->viewFactory->make('twill.settings.' . $section, [
             'customForm' => true,
             'editableTitle' => false,
             'customTitle' => ucfirst($section) . ' settings',
             'section' => $section,
-            'form_fields' => $this->settings->getFormFieldsForSection($section),
+            'form_fields' => $formFields,
             'formBuilder' => Form::make(),
             'saveUrl' => $this->urlGenerator->route(config('twill.admin_route_name_prefix') . 'settings.update', $section),
             'translate' => true,
-        ])
-        : $this->redirector->back();
+        ]);
     }
 
     /**