Fix getBaseNamespace #2420
Merged
Fix getBaseNamespace #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifox
approved these changes
Feb 10, 2024
AidasK
pushed a commit
to AidasK/twill
that referenced
this pull request
May 4, 2024
* Fix getBaseNamespace * Add tests * Given getBasePath is broken and not used anywhere, remove it * Fix tests * Update CapsulesTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running getBaseNameSpace on a capsule will throw an error
implode(): Argument #2 ($array) must be of type ?array, string givenbecause array_pop returns the last element of the array which is given to implode, but the name of the function means that we instead want the namespace without the last elementThis function is not used anywhere though in the core, I only caught it while doing some tinkering
Maybe we should add phpstan to the project for static analysis which would catch exactly this kind of issues