Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes: Made changes on header and footer part #1055

Closed
wants to merge 12 commits into from

Conversation

Bhumika1312
Copy link

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
#147

Description

[Please include a brief description of the changes or features added]
Have made some changes in header and footer part to make it similar with the original one

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flipkart-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 5:23am

@Bhumika1312
Copy link
Author

Bhumika1312 commented Jun 6, 2024

@arghadipmanna101 Can you check this I have made changes on the updated clone also can you please assign this to me and add levels and label of gssoc

@arghadipmanna101
Copy link
Owner

Not look good.

image

@Bhumika1312
Copy link
Author

image
Sir I have made footer like this

@arghadipmanna101
Copy link
Owner

There have some conflict issue check it once

@Bhumika1312
Copy link
Author

@arghadipmanna101 can you now check now

@arghadipmanna101
Copy link
Owner

The previous footer is better and original as flipkart.

@Bhumika1312
Copy link
Author

So sir what changes should I do I have also updated header file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants