Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to demonstrate some problems with the current resampling code & usage, and propose a new implementation.
The current resampling code and usage has the following issues:
loadAudioFailed("Failed to process audio buffer")
on certain inputs - e.g. for 44.1khz files with frame counts of 12289 + 1024*N.AVAudioPCMBuffer
returned fromAudioProcessor.loadAudio()
and the[Float]
returned fromAudioProcessor.convertBufferToArray()
are retained for the entire duration of the innertranscribe(audioArray: ...)
call.The included tests attempt to demonstrate the problem and stress-test a proposed implementation via the use of dynamically created silent files of arbitrary lengths and sample rates.