Skip to content

Commit

Permalink
display the warning instead of returning an error
Browse files Browse the repository at this point in the history
Signed-off-by: Rizwana777 <[email protected]>
  • Loading branch information
Rizwana777 committed Jan 24, 2025
1 parent 4e9d634 commit 225aacc
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions controllers/argocd/argocd_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,9 @@ func (r *ReconcileArgoCD) internalReconcile(ctx context.Context, request ctrl.Re
return reconcile.Result{}, argocd, err
}

// If the number of notification replicas is greater than 1, return an error
// If the number of notification replicas is greater than 1, display a warning.
if argocd.Spec.Notifications.Replicas != nil && *argocd.Spec.Notifications.Replicas > 1 {
message := "Argo CD Notification controller does not support multiple replicas. Notification replicas cannot be greater than 1."
reqLogger.Info(message)
return reconcile.Result{}, argocd, fmt.Errorf("%s", message)
reqLogger.Info("WARNING: Argo CD Notification controller does not support multiple replicas. Notification replicas cannot be greater than 1.")
}

// Fetch labelSelector from r.LabelSelector (command-line option)
Expand Down

0 comments on commit 225aacc

Please sign in to comment.