code-refactoring: Add argocd server controller #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svghadi
changed the title
chengfang
reviewed
Nov 14, 2023
jaideepr97
reviewed
Nov 15, 2023
jaideepr97
reviewed
Nov 15, 2023
jaideepr97
reviewed
Nov 15, 2023
jaideepr97
reviewed
Dec 8, 2023
jaideepr97
reviewed
Dec 8, 2023
jaideepr97
reviewed
Dec 8, 2023
jaideepr97
reviewed
Dec 8, 2023
svghadi
force-pushed
the
server-pkg-redesign
branch
6 times, most recently
from
cda0cd4 to
03d6e07
Compare
2 tasks
jaideepr97
reviewed
Jan 17, 2024
jaideepr97
reviewed
Jan 17, 2024
jaideepr97
reviewed
Jan 17, 2024
jaideepr97
reviewed
Jan 17, 2024
jaideepr97
reviewed
Jan 17, 2024
|
@svghadi added some generic comments that should be applied across all resources managed by the server Additionally, please make sure to move all the server related functions that you have already implemented from the old code into the correct |
svghadi
force-pushed
the
server-pkg-redesign
branch
from
03d6e07 to
30a8fc3
Compare
svghadi
force-pushed
the
server-pkg-redesign
branch
from
30a8fc3 to
2dec80f
Compare
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
force-pushed
the
server-pkg-redesign
branch
from
2dec80f to
e71feaa
Compare
Signed-off-by: Siddhesh Ghadi <[email protected]>
jaideepr97
merged commit 22338f2
into
argoproj-labs:operator-redesign
1 of 3 checks passed
Julik24
pushed a commit
to Julik24/argocd-operator
that referenced
this pull request
Apr 24, 2024
* add server controller --------- Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
Adds server controller
How to test changes / Special notes to the reviewer: