-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: update main.go, go mod files and docs (3/8) #1135
rebase: update main.go, go mod files and docs (3/8) #1135
Conversation
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
…perator into op-redesign-rebase-3
…perator into op-redesign-rebase-2
…perator into op-redesign-rebase-3
…perator into op-redesign-rebase-3
Signed-off-by: Jaideep Rao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few rebase issues left in the code. The rest looks good.
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
f1cbb48
into
argoproj-labs:operator-redesign
* update main.go, go mod files, docs --------- Signed-off-by: Jaideep Rao <[email protected]
What type of PR is this?
What does this PR do / why we need it:
3/8 PRs to rebase the redesgin branch
This PR does:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: