-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/8) #1136
Merged
jaideepr97
merged 10 commits into
argoproj-labs:operator-redesign
from
jaideepr97:op-redesign-rebase-4
Jan 9, 2024
Merged
rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/8) #1136
jaideepr97
merged 10 commits into
argoproj-labs:operator-redesign
from
jaideepr97:op-redesign-rebase-4
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
…perator into op-redesign-rebase-3
…perator into op-redesign-rebase-4
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
svghadi
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 rebase issues. Rest all looks good.
Signed-off-by: Jaideep Rao <[email protected]>
svghadi
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
fabd487
into
argoproj-labs:operator-redesign
1 of 3 checks passed
Julik24
pushed a commit
to Julik24/argocd-operator
that referenced
this pull request
Apr 24, 2024
…ackages (4/8) (argoproj-labs#1136) * update cluster, mutation, util and monitoring in pkg --------- Signed-off-by: Jaideep Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
4/8 PRs to rebase the redesign branch
This PR does:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: