Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/8) #1136

Merged

Conversation

jaideepr97
Copy link
Collaborator

@jaideepr97 jaideepr97 commented Jan 5, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
4/8 PRs to rebase the redesign branch

This PR does:

  • update pkg/cluster
  • update pkg/monitoring
  • update pkg/mutation
  • update pkg/util
  • update argocd/argocdcommon

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@jaideepr97 jaideepr97 changed the title rebase: update cluster, mutation, util and monitoring packages (4/?) rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/?) Jan 5, 2024
@jaideepr97 jaideepr97 changed the title rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/?) rebase: update cluster, mutation, util, argocdcommon and monitoring packages (4/8) Jan 8, 2024
Signed-off-by: Jaideep Rao <[email protected]>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 rebase issues. Rest all looks good.

docs/reference/argocd.md Outdated Show resolved Hide resolved
docs/reference/argocd.md Outdated Show resolved Hide resolved
Signed-off-by: Jaideep Rao <[email protected]>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@jaideepr97 jaideepr97 merged commit fabd487 into argoproj-labs:operator-redesign Jan 9, 2024
1 of 3 checks passed
@jaideepr97 jaideepr97 deleted the op-redesign-rebase-4 branch February 14, 2024 18:43
Julik24 pushed a commit to Julik24/argocd-operator that referenced this pull request Apr 24, 2024
…ackages (4/8) (argoproj-labs#1136)

* update cluster, mutation, util and monitoring in pkg
---------

Signed-off-by: Jaideep Rao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants