Only update Argo CD Cluster secret if the values have changed #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
minor typo, LGTM |
Rizwana777
reviewed
Jan 28, 2025
Signed-off-by: Jonathan West <[email protected]>
jgwest
force-pushed
the
improve-secret-creation
branch
from
c57cabc to
dd56e60
Compare
|
Thanks @Rizwana777! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Currently, the Argo CD operator will update the default cluster Secret after every reconcile, regardless of whether or not the
.data.namespacesfield has actually changed.This PR updates the logic to only update
.data.namespacesif the field has changed.