Skip to content

Commit

Permalink
chore: Add some empty dir volume mounts for the application controller (
Browse files Browse the repository at this point in the history
#19474)

Closes #19474

Kube cache couldn't be used on read-only root file system leading to errors as revealed with `--gloglevel` equal to 6.
Create an empty dir mount for `/tmp` and add a config-map-based param to override `KUBECACHEDIR`.

Signed-off-by: Andrii Korotkov <[email protected]>
  • Loading branch information
andrii-korotkov-verkada committed Aug 12, 2024
1 parent 4a7a82c commit cf327a4
Show file tree
Hide file tree
Showing 7 changed files with 62 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/operator-manual/argocd-cmd-params-cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ data:
controller.diff.server.side: "false"
# Enables profile endpoint on the internal metrics port
controller.profile.enabled: "false"
# Changes the directory for kube caching, useful when root filesystem is readonly. E.g. put it somewhere in /tmp as it's mounted as an empty dir. Defaults to $HOME/.kube/cache.
controller.kubecachedir:

## Server properties
# Listen on given address for incoming connections (default "0.0.0.0")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,12 @@ spec:
name: argocd-cmd-params-cm
key: controller.ignore.normalizer.jq.timeout
optional: true
- name: KUBECACHEDIR
valueFrom:
configMapKeyRef:
key: controller.kubecachedir
name: argocd-cmd-params-cm
optional: true
image: quay.io/argoproj/argocd:latest
imagePullPolicy: Always
name: argocd-application-controller
Expand Down Expand Up @@ -236,6 +242,8 @@ spec:
mountPath: /home/argocd
- name: argocd-cmd-params-cm
mountPath: /home/argocd/params
- name: argocd-application-controller-tmp
mountPath: /tmp
serviceAccountName: argocd-application-controller
affinity:
podAntiAffinity:
Expand All @@ -255,6 +263,8 @@ spec:
volumes:
- emptyDir: {}
name: argocd-home
- emptyDir: {}
name: argocd-application-controller-tmp
- name: argocd-repo-server-tls
secret:
secretName: argocd-repo-server-tls
Expand Down
10 changes: 10 additions & 0 deletions manifests/core-install.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions manifests/ha/install.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions manifests/ha/namespace-install.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions manifests/install.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions manifests/namespace-install.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit cf327a4

Please sign in to comment.