Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move basic auth for for Azure DevOps to webhooks lib #19407

Merged

Conversation

robinlieb
Copy link
Member

@robinlieb robinlieb commented Aug 6, 2024

Basic auth for Azure Webhooks was added to the webhooks library in this PR: go-playground/webhooks#191
Which was released with version 6.4.0: https://github.com/go-playground/webhooks/releases/tag/v6.4.0

This change removes the basic auth check for Azure DevOps to remove complexity since this is now included in the underlying library.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@robinlieb robinlieb requested a review from a team as a code owner August 6, 2024 17:40
Copy link

bunnyshell bot commented Aug 6, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 6, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev
Copy link
Member

Is there any testing we can/should have here?

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (da1e95d) to head (d32649c).
Report is 503 commits behind head on master.

Files with missing lines Patch % Lines
util/webhook/webhook.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19407      +/-   ##
==========================================
+ Coverage   52.84%   52.85%   +0.01%     
==========================================
  Files         316      316              
  Lines       43656    43636      -20     
==========================================
- Hits        23069    23065       -4     
+ Misses      18032    18020      -12     
+ Partials     2555     2551       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinlieb robinlieb force-pushed the feat/azure-devops-webhook-basic-auth branch from 84a3ea0 to c4cf564 Compare August 6, 2024 19:07
@robinlieb
Copy link
Member Author

@crenshaw-dev tests for basic auth in Azure DevOps (and secrets for other SCM providers) are already included in the lib. Not sure if it's required in that case. Do you have anything specific in mind?

@robinlieb robinlieb force-pushed the feat/azure-devops-webhook-basic-auth branch from c4cf564 to d32649c Compare August 7, 2024 15:34
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) August 7, 2024 15:34
@crenshaw-dev crenshaw-dev merged commit 4f64f0f into argoproj:master Aug 7, 2024
27 of 28 checks passed
ilia-medvedev-codefresh pushed a commit to ilia-medvedev-codefresh/argo-cd that referenced this pull request Aug 13, 2024
reggie-k pushed a commit to reggie-k/argo-cd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants