Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appset): Provide additional parameter files to git generator - Fixes #20593 #20653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Nov 4, 2024

Fixes #20593

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested review from a team as code owners November 4, 2024 17:00
Copy link

bunnyshell bot commented Nov 4, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-huawyy.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-huawyy.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 88.34951% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.13%. Comparing base (36ef563) to head (f8f5a0f).

Files with missing lines Patch % Lines
applicationset/generators/git.go 86.51% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20653      +/-   ##
==========================================
+ Coverage   55.10%   55.13%   +0.03%     
==========================================
  Files         324      324              
  Lines       55239    55319      +80     
==========================================
+ Hits        30439    30500      +61     
- Misses      22180    22198      +18     
- Partials     2620     2621       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OpenGuidou OpenGuidou force-pushed the 20593-gitgen branch 3 times, most recently from 0577c89 to 332728c Compare November 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance git generator with parameter files
1 participant