Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompting to confirm project window deletion #20656

Conversation

pasha-codefresh
Copy link
Member

Related to: #19528

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner November 4, 2024 19:36
Copy link

bunnyshell bot commented Nov 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@8cf990b). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/repo.go 0.00% 10 Missing ⚠️
cmd/argocd/commands/projectwindows.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20656   +/-   ##
=========================================
  Coverage          ?   55.17%           
=========================================
  Files             ?      324           
  Lines             ?    55213           
  Branches          ?        0           
=========================================
  Hits              ?    30465           
  Misses            ?    22134           
  Partials          ?     2614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 2620593 into argoproj:master Nov 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants