Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing 2.12 upgrade page to nav menu #20657

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

fletch3555
Copy link

This PR targets 2.12 docs directly as it has already been resolved in release-2.13 and master.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@fletch3555 fletch3555 requested review from a team as code owners November 4, 2024 20:59
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once you signoff your commit

@fletch3555
Copy link
Author

LGTM, once you signoff your commit

Is it not?
image

The DCO check is successful which (as far as I was aware) indicates the commits are properly signed-off. I do see several failed E2E tests, but not sure why that is since I didn't touch any code.

I'm new to contributing to this project, so a little bit of guidance/hand-holding would be very much appreciated. Thanks!

@blakepettersson
Copy link
Member

@fletch3555 nm, I could've sworn that was an issue - in any case LGTM.

@blakepettersson blakepettersson merged commit 57cef1d into argoproj:release-2.12 Nov 5, 2024
15 of 21 checks passed
@fletch3555 fletch3555 deleted the patch-1 branch November 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants