chore: Don't degrade PDB on InsufficientPods (#20171) #20665
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
andrii-korotkov-verkada
force-pushed
the
20171-dont-degrade-pdb-on-insufficient-pods
branch
2 times, most recently
from
0cff32a
to
5b76ced
Compare
Closes argoproj#20171 There are valid use cases for InsufficientPods, e.g. running some jobs or tests that don't want to be terminated. See the discussion on the issue for more details. So don't degrade the PDB on InsufficientPods condition. This needs to be cherry picked to 2.13, as many people may not upgrade otherwise. Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada
force-pushed
the
20171-dont-degrade-pdb-on-insufficient-pods
branch
from
5b76ced
to
8f645d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20665 +/- ##
=========================================
Coverage ? 55.09%
=========================================
Files ? 324
Lines ? 55239
Branches ? 0
=========================================
Hits ? 30433
Misses ? 22190
Partials ? 2616 ☔ View full report in Codecov by Sentry. |
rumstead
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20171
There are valid use cases for InsufficientPods, e.g. running some jobs or tests that don't want to be terminated. See the discussion on the issue for more details. So don't degrade the PDB on InsufficientPods condition.
This needs to be cherry picked to 2.13, as many people may not upgrade otherwise.
Checklist: