Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fine grained update delete RBAC w/ v3 gate #20671

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Fine grained update delete RBAC w/ v3 gate #20671

wants to merge 3 commits into from
+495 −4

Commits on Nov 5, 2024

  1. Enable fine-grained update/delete RBAC enforcement by default (argopr… 

    …oj#19988)

Change applications resource RBAC to use fine-grained update/delete
enforcement by default. This allows us to enforce RBAC on the
application itself, separately from the sub-resources related to it.

(see also argoproj#18124, argoproj#20600)

Signed-off-by: Matt Finkel <[email protected]>
    @fffinkel
    fffinkel committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a5f8e15 View commit details
    Browse the repository at this point in the history

  2. Add config setting to preserve V2 update/delete RBAC (argoproj#20600) 

    A breaking change was introduced in a previous commit that is planned to
be a part of the next major version of Argo CD (v3) where it's okay to
introduce breaking changes. We want this feature before we hit v3, so
we add a config setting that allows us to explicitly turn this new v3
behavior on in v2. The current v2 behavior is the default, so this
change will not affect folks who do not explicitly opt in.

This commit to add the gating code is added separately so it will be
easy to either cherry pick that pervious commit or revert this one.

(see also argoproj#18124, argoproj#19988)

Signed-off-by: Matt Finkel <[email protected]>
    @fffinkel
    fffinkel committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bfb52e4 View commit details
    Browse the repository at this point in the history

  3. Add ZipRecruiter to USERS.md 

    Signed-off-by: Matt Finkel <[email protected]>
    @fffinkel
    fffinkel committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f258ae5 View commit details
    Browse the repository at this point in the history