Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkce): 20202 Backport PKCE auth flow fix for basehref and reauth #20675

Open
wants to merge 2 commits into
base: release-2.13
Choose a base branch
from
Open

fix(pkce): 20202 Backport PKCE auth flow fix for basehref and reauth #20675

wants to merge 2 commits into from
+78 −28

Conversation

austin5219
Copy link
Contributor

@austin5219 austin5219 commented Nov 5, 2024 •
edited
Loading

This backports 20202 to 2.13

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@austin5219
fix(pkce): 20111 PKCE auth flow does not return user to previous path…
61e7ad1 
… like dex auth flow (argoproj#20202)

* Adding non-default basehref support for PKCE auth flow

Signed-off-by: austin5219 <[email protected]>

* Adding ; for linting

Signed-off-by: austin5219 <[email protected]>

* removing hook function

Signed-off-by: austin5219 <[email protected]>

* Moving unauthorized error handling to class component to access context for error handling within 401 error

Signed-off-by: austin5219 <[email protected]>

* Store the subsrition handle to close in unmount

Signed-off-by: austin5219 <[email protected]>

* reorder imports

Signed-off-by: austin5219 <[email protected]>

* Actually saving the subscriptions now

Signed-off-by: austin5219 <[email protected]>

* returning the 401 subscription from helper function

Signed-off-by: austin5219 <[email protected]>

* Handle the promise of a subscription

Signed-off-by: austin5219 <[email protected]>

* Removing then from non async subscribe

Signed-off-by: austin5219 <[email protected]>

* Linter fixes

Signed-off-by: austin5219 <[email protected]>

* Adding path caching to sessionStorage on pkceLogin and redirect step to cached path if available in pkceCallback to mirror Dex functionality

Signed-off-by: austin5219 <[email protected]>

---------

Signed-off-by: austin5219 <[email protected]>
@austin5219 austin5219 requested a review from a team as a code owner November 5, 2024 21:45
@austin5219
Merge Conflict fix
47ab083 
Signed-off-by: austin5219 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@austin5219