Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move appset delete confirmation to new prompt logic #20677

Conversation

pasha-codefresh
Copy link
Member

Related to: #19528

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner November 6, 2024 09:23
Copy link

bunnyshell bot commented Nov 6, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (b9d5387) to head (a42ee51).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/applicationset.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20677      +/-   ##
==========================================
+ Coverage   55.10%   55.19%   +0.08%     
==========================================
  Files         324      324              
  Lines       55262    55256       -6     
==========================================
+ Hits        30452    30496      +44     
+ Misses      22183    22153      -30     
+ Partials     2627     2607      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@pasha-codefresh pasha-codefresh merged commit 4a38442 into argoproj:master Nov 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants