fix(appset): new globbing not used until cache expires #21686
+153
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
❗ Preview Environment stop on Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
crenshaw-dev
approved these changes
Feb 3, 2025
crenshaw-dev
reviewed
Feb 3, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| cwd, err = os.Getwd() |
There was a problem hiding this comment.
Suggested change
| cwd, err = os.Getwd() | |
| // Depending on the OS, this can be different from m.root. Get the OS-specific path | |
| // for cross-platform compatibility. | |
| cwd, err = os.Getwd() |
There was a problem hiding this comment.
Are they different because os.Getwd() is indeterministic when a folder can be reached by multiple paths via symlinks?
rumstead
approved these changes
Feb 5, 2025
rumstead
reviewed
Feb 5, 2025
| @@ -421,10 +421,16 @@ func (m *nativeGitClient) Fetch(revision string) error { | |||
| func (m *nativeGitClient) LsFiles(path string, enableNewGitFileGlobbing bool) ([]string, error) { | |||
| if enableNewGitFileGlobbing { | |||
| // This is the new way with safer globbing | |||
| err := os.Chdir(m.root) | |||
| cwd := m.root | |||
There was a problem hiding this comment.
Just for my understanding, this was just added for debugging and doesn't make any material change?
Signed-off-by: Alexandre Gaudreault <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21686 +/- ##
==========================================
+ Coverage 55.59% 55.63% +0.04%
==========================================
Files 340 339 -1
Lines 57419 56818 -601
==========================================
- Hits 31924 31613 -311
+ Misses 22807 22555 -252
+ Partials 2688 2650 -38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using appset with
applicationsetcontroller.enable.new.git.file.globbing: "true", it takes up to 24h hours for the new globbing to apply. This is because the repo server contains a cache that by default expires every 24h.To prevent this, the globbing algorithm used is used along with the pattern in the cache key.
New tests were to the new globbing to clarify it's behaviour, and a problem was found were, depending on the OS,
chdir(m.root)can set a different value thanm.rootas the working directory.For instance, during the unit test, on MacOs,
/var/tmp/....will result in/private/var/tmp/....when used as a current working directory.