fix: Limit only accepted events in Kafka event source #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Vasilyev <[email protected]>
|
This Pull Request is stale because it has been open for 60 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to fix an issue with heavy loaded Kafka EventSource with filtration (when the number of filtered out events is much greater than the accepted). The rate limitation is now applied to accepted events only, and filtration speed does not slow down.
Another outcome is that (potentially) adding LimitEventsPerSecond property to other EventSources in the future will be simpler.
I haven't found a proper place to add unit tests, so tested the change in our in-house Argo Events instance in K8s.