Feat/recursive file events #2977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenD32
force-pushed
the
feat/recursive-file-events
branch
3 times, most recently
from
b66db66 to
3b2963c
Compare
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
…proj#2966) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: AmitMendl <[email protected]>
….0 to 2.9.0 (argoproj#2967) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: zhaowei.wang <[email protected]> Co-authored-by: zhaowei.wang <[email protected]> Signed-off-by: AmitMendl <[email protected]>
…goproj#2968) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: Derek Wang <[email protected]> Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
MenD32
force-pushed
the
feat/recursive-file-events
branch
from
6b7080e to
1e11621
Compare
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
Signed-off-by: AmitMendl <[email protected]>
|
I cant figure out why but for some reason |
whynowy
reviewed
Jan 27, 2024
| @@ -16,8 +16,8 @@ EXECUTABLES = curl docker gzip go | |||
| # docker image publishing options | |||
| DOCKER_PUSH?=false | |||
| IMAGE_NAMESPACE?=quay.io/argoproj | |||
| VERSION?=latest | |||
| BASE_VERSION:=latest | |||
| VERSION?=v1.9.0 | |||
| log.Errorw("failed getting filestat", zap.Error(err)) | ||
| } | ||
| if fileinfo.IsDir() { | ||
| err = watcher.Add(event.Name) |
There was a problem hiding this comment.
- If there is a dir create with sub directories (folder A contains B, B contains C), how many events are supposed to get? will it have duplicated processing?
- No eviction mechanism for deleting?
|
This Pull Request is stale because it has been open for 60 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Add FileEventSource support for recursive file events