fix(controller): Set the rollout replica field to the previous revision replica count. Fixes #3689

[jamsesso]

Fixes #3689

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jamsesso]

I think there is a lingering bug here, still. I believe that, even in this case, we should not set this to a static value of 1 - that seems to break the configuration value of minPodsPerReplicaSet. While not necessarily related to the bug, I wanted to point this logic out to the maintainers for comment.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 35m 9s ⏱️
114 tests  62 ✅  7 💤 45 ❌
391 runs  321 ✅ 25 💤 45 ❌

For more details on these failures, see this check.

Results for commit 8eb148f.

[github-actions]

Published Unit Test Results

2 294 tests   2 294 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 8eb148f.

[jamsesso]

My e2e tests on K8s 1.28 failed, all with an ImagePullBackoff error. This is unrelated, but I don't have permissions (?) to re-run the job to get to green.