fix(ci): Download Go modules before linting to resolve TypeCheck errors #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Harvey <[email protected]>
adamdmharvey
changed the title
Signed-off-by: Adam Harvey <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 55.13% 55.13%
=======================================
Files 35 35
Lines 3337 3337
=======================================
Hits 1840 1840
Misses 1230 1230
Partials 267 267 ☔ View full report in Codecov by Sentry. |
|
Looks like it is working now, should we close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some reports on TypeCheck errors in golangci/golangci-lint-action#902. These are similar to what we see with #256, #255, and #254.
The linter in v1.54 seemed to deprecate some of the TypeChecking errors, and so I've bumped the linter up also (which seemed to fix the problem).