helm: generate chart from k8s manifest #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
force-pushed
the
g/auto-gen-helm
branch
4 times, most recently
from
3e6c934
to
d36ad53
Compare
giautm
changed the title
giautm
force-pushed
the
g/auto-gen-helm
branch
2 times, most recently
from
81e3a28
to
61e7db8
Compare
giautm
force-pushed
the
g/auto-gen-helm
branch
2 times, most recently
from
0cd127a
to
bfe79b5
Compare
giautm
force-pushed
the
g/auto-gen-helm
branch
from
bfe79b5
to
ed2186a
Compare
giautm
force-pushed
the
g/auto-gen-helm
branch
2 times, most recently
from
3a4a4b5
to
d4b7d83
Compare
This commit is a breaking change due to values.yaml changed
giautm
force-pushed
the
g/auto-gen-helm
branch
from
d4b7d83
to
c037d5c
Compare
giautm
force-pushed
the
g/auto-gen-helm
branch
from
c037d5c
to
69d1b6c
Compare
|
This PR introduces Breaking Change in the term of customize if the user installs our chart with custom values. But it's easy to change to the new charts. This allows us to keep the chart consistent with k8s manifest and doesn't have to write it manually. |
giautm
requested review from
rotemtam and
datdao
and removed request for
rotemtam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.