add tests for mssql (#11)

ariga · Jan 26, 2024 · a50b3c4 · a50b3c4
1 parent 52142fd
commit a50b3c4
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -32,7 +32,7 @@ jobs:
   integration-tests:
     strategy:
       matrix:
-        dialect: [ mysql, postgresql, sqlite ]
+        dialect: [ mysql, postgresql, sqlite, mssql ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -59,6 +59,8 @@ jobs:
         working-directory: ./tests
         run: |
           atlas migrate diff --env sqlalchemy -c "file://atlas-standalone.hcl" --var dialect=${{ matrix.dialect }}
+        env:
+          ATLAS_TOKEN: ${{ secrets.ATLAS_TOKEN }}
       - name: Verify migrations generated
         working-directory: ./tests
         run: |
@@ -74,6 +76,8 @@ jobs:
         run: |
           export PYTHONPATH=$PYTHONPATH:$(cd ../ && pwd)
           atlas migrate diff --env sqlalchemy -c "file://atlas-script.hcl" --var dialect=${{ matrix.dialect }}
+        env:
+          ATLAS_TOKEN: ${{ secrets.ATLAS_TOKEN }}
       - name: Verify migrations generated
         working-directory: ./tests
         run: |

diff --git a/tests/atlas-script.hcl b/tests/atlas-script.hcl
@@ -7,6 +7,7 @@ locals {
     mysql = "docker://mysql/8/dev"
     postgresql = "docker://postgres/15"
     sqlite = "sqlite://?mode=memory&_fk=1"
+    mssql = "docker://sqlserver/2022-latest"
   }[var.dialect]
 }
 
@@ -16,7 +17,7 @@ data "external_schema" "sqlalchemy" {
     "run",
     "python3",
     "load_models.py",
-    var.dialect, // mysql | postgresql | sqlite | mssql+pyodbc
+    var.dialect, // mysql | postgresql | sqlite | mssql
   ]
 }
 

diff --git a/tests/atlas-standalone.hcl b/tests/atlas-standalone.hcl
@@ -7,6 +7,7 @@ locals {
     mysql = "docker://mysql/8/dev"
     postgresql = "docker://postgres/15"
     sqlite = "sqlite://?mode=memory&_fk=1"
+    mssql = "docker://sqlserver/2022-latest"
   }[var.dialect]
 }
 
@@ -17,7 +18,7 @@ data "external_schema" "sqlalchemy" {
     "python3",
     "../atlas_provider_sqlalchemy/main.py",
     "--path", "models",
-    "--dialect", var.dialect, // mysql | postgresql | sqlite | mssql+pyodbc
+    "--dialect", var.dialect, // mysql | postgresql | sqlite | mssql
   ]
 }
 

diff --git a/tests/migrations/mssql/20240125192026.sql b/tests/migrations/mssql/20240125192026.sql
@@ -0,0 +1,16 @@
+-- Create "user_account" table
+CREATE TABLE [user_account] (
+  [id] int IDENTITY (1, 1) NOT NULL,
+  [name] varchar(30) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL,
+  [fullname] varchar(30) COLLATE SQL_Latin1_General_CP1_CI_AS NULL,
+  CONSTRAINT [PK_user_account] PRIMARY KEY CLUSTERED ([id] ASC)
+);
+-- Create "address" table
+CREATE TABLE [address] (
+  [id] int IDENTITY (1, 1) NOT NULL,
+  [email_address] varchar(30) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL,
+  [user_id] int NOT NULL,
+  CONSTRAINT [PK_address] PRIMARY KEY CLUSTERED ([id] ASC),
+
+  CONSTRAINT [FK__address__user_id__22CA2527] FOREIGN KEY ([user_id]) REFERENCES [user_account] ([id]) ON UPDATE NO ACTION ON DELETE NO ACTION
+);
diff --git a/tests/migrations/mssql/atlas.sum b/tests/migrations/mssql/atlas.sum
@@ -0,0 +1,2 @@
+h1:067sNKWwxUzYEHi3IysI6sfgmplP9lwYZvsdR4pj8lw=
+20240125192026.sql h1:t14KpnQqIepqloh4dAmKkRZHC8lGKuLAY6Tbdhz31jg=
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		h1:067sNKWwxUzYEHi3IysI6sfgmplP9lwYZvsdR4pj8lw=
		20240125192026.sql h1:t14KpnQqIepqloh4dAmKkRZHC8lGKuLAY6Tbdhz31jg=