-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anta): Added strict check to VerifyBGPPeerMPCaps test to verify only mentioned multiprotocol capabilities of a BGP peer should be listed #783
Merged
carl-baillargeon
merged 8 commits into
aristanetworks:main
from
vitthalmagadum:issue_781
Sep 4, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
reviewed
Aug 8, 2024
vitthalmagadum
force-pushed
the
issue_781
branch
from
August 13, 2024 13:42
3e9e8d6
to
1b40da2
Compare
MaheshGSLAB
reviewed
Aug 14, 2024
vitthalmagadum
force-pushed
the
issue_781
branch
from
August 16, 2024 10:11
1b40da2
to
da4447e
Compare
vitthalmagadum
force-pushed
the
issue_781
branch
from
August 26, 2024 11:48
e6fc903
to
7db43d6
Compare
vitthalmagadum
force-pushed
the
issue_781
branch
from
August 28, 2024 07:24
7db43d6
to
ea46614
Compare
Quality Gate passedIssues Measures |
carl-baillargeon
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added strict check to VerifyBGPPeerMPCaps test to verify only mentioned multiprotocol capabilities of a BGP peer should be listed
Fixes #781
Checklist:
pre-commit run
)tox -e testenv
)